Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cedato new bid adapter #3629

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Cedato new bid adapter #3629

merged 2 commits into from
Mar 26, 2019

Conversation

alexkh13
Copy link
Contributor

@alexkh13 alexkh13 commented Mar 13, 2019 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'cedato',
  params: {
    player_id: 1450133326
  }
}
  • official adapter submission

@robertrmartinez
Copy link
Collaborator

@alexkh13 This is marked as a draft, are you planning on adding some updates?

Or is it ready for a full review?

@alexkh13 alexkh13 marked this pull request as ready for review March 19, 2019 12:28
@alexkh13
Copy link
Contributor Author

@robertrmartinez Yes, this pull request is ready for review.

Test parameters has been updated.

@alexkh13
Copy link
Contributor Author

prebid/prebid.github.io#1215

@robertrmartinez
Copy link
Collaborator

Starting the review now.

Should be done shortly and we can get this into Tomorrows release!

@robertrmartinez
Copy link
Collaborator

Sorry accidentally clicked close!

@robertrmartinez
Copy link
Collaborator

@alexkh13 Hey this looks good.

But I want to point out / inquire about potentially passing the GDPR parameters?

If a publisher wishes to use Cedato, is there a way this bid adapter plans on handling GDPR consent?

Prebid will send a gdprApplies flag as well as the actual consent string.

This is accessible by both the bidderRequest object sent in by prebid:

image

As well as an optional gdprConsent object which can be sent into the getUserSyncs function!

image

Please get back to me and let me know if you will be adding these!

@robertrmartinez
Copy link
Collaborator

Example adapter of passing it along in the bidderRequest:

https://github.com/prebid/Prebid.js/blob/master/modules/appnexusBidAdapter.js#L146

User Sync:

https://github.com/prebid/Prebid.js/blob/master/modules/rubiconBidAdapter.js#L556

Please note that if consentManagement is enabled in the setConfig,

And Prebid was not able to get consent, but the auction is still allowed to occur,

Then the gdprConsent object is still passed, BUT it contains undefined values for each of the keys passed.

@robertrmartinez robertrmartinez self-requested a review March 25, 2019 18:38
robertrmartinez
robertrmartinez requested changes Mar 25, 2019
View reviewed changes
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexkh13
Requesting Changes until I hear back regarding GDPR params!

@alexkh13
Copy link
Contributor Author

@robertrmartinez
Added support for GDPR in the adapter

robertrmartinez
robertrmartinez approved these changes Mar 26, 2019
View reviewed changes
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome looks good to me!

@robertrmartinez robertrmartinez merged commit c1fbba2 into prebid:master Mar 26, 2019
pycnvr pushed a commit to conversant/Prebid.js that referenced this pull request Apr 4, 2019
@alexkh13 @pycnvr
Cedato new bid adapter (prebid#3629)
63eac35 
* Cedato new bid adapter

* Added GDPR support for Cedato bid adapter
@alexkh13 alexkh13 deleted the cedatoBidAdapter-release branch May 13, 2019 12:28
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
@alexkh13 @jacekburys-quantcast
Cedato new bid adapter (prebid#3629)
0cf8d29 
* Cedato new bid adapter

* Added GDPR support for Cedato bid adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertrmartinez robertrmartinez robertrmartinez approved these changes

Assignees

@robertrmartinez robertrmartinez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexkh13 @robertrmartinez